From 68e791512551261fd805f841fd88aba373df845a Mon Sep 17 00:00:00 2001 From: srichman333 Date: Mon, 26 Jun 2023 15:02:12 -0400 Subject: layout always an option in SharingManager, current user layout acl bug fix in PropertiesView + SharingManager --- src/client/util/SharingManager.scss | 1 + src/client/util/SharingManager.tsx | 54 +++++++++++++++++-------------------- 2 files changed, 26 insertions(+), 29 deletions(-) (limited to 'src/client/util') diff --git a/src/client/util/SharingManager.scss b/src/client/util/SharingManager.scss index 98fea0dcb..86de5ac44 100644 --- a/src/client/util/SharingManager.scss +++ b/src/client/util/SharingManager.scss @@ -86,6 +86,7 @@ float: right; align-items: baseline; margin-top: -12; + margin-bottom: 10; .layoutDoc-acls, .myDocs-acls { diff --git a/src/client/util/SharingManager.tsx b/src/client/util/SharingManager.tsx index 0f7ce26d2..7593cc025 100644 --- a/src/client/util/SharingManager.tsx +++ b/src/client/util/SharingManager.tsx @@ -539,21 +539,11 @@ export class SharingManager extends React.Component<{}> { // const permissions = uniform ? StrCast(targetDoc?.[userKey]) : '-multiple-'; let permissions = this.layoutDocAcls ? (targetDoc[DocAcl][userKey] ? HierarchyMapping.get(targetDoc[DocAcl][userKey])?.name : StrCast(Doc.GetProto(targetDoc)[userKey])) : StrCast(targetDoc[userKey]); if (this.layoutDocAcls){ - if (targetDoc[DocAcl][userKey]){ - permissions = HierarchyMapping.get(targetDoc[DocAcl][userKey])?.name; - } - else{ - if (targetDoc['embedContainer']){ - permissions = StrCast(Doc.GetProto(DocCast(targetDoc['embedContainer']))[userKey]); - } - else{ - permissions = uniform ? StrCast(Doc.GetProto(targetDoc)?.[userKey]) : '-multiple-'; - } - } - } - else{ - permissions = uniform ? StrCast(targetDoc?.[userKey]) : '-multiple-'; + if (targetDoc[DocAcl][userKey]) permissions = HierarchyMapping.get(targetDoc[DocAcl][userKey])?.name; + else if (targetDoc['embedContainer']) permissions = StrCast(Doc.GetProto(DocCast(targetDoc['embedContainer']))[userKey]); + else permissions = uniform ? StrCast(Doc.GetProto(targetDoc)?.[userKey]) : '-multiple-'; } + else permissions = uniform ? StrCast(targetDoc?.[userKey]) : '-multiple-'; return !permissions ? null : (
@@ -578,7 +568,15 @@ export class SharingManager extends React.Component<{}> { const sameAuthor = docs.every(doc => doc?.author === docs[0]?.author); // the owner of the doc and the current user are placed at the top of the user list. - const curUserPermission = HierarchyMapping.get(effectiveAcls[0])!.name + const userKey = `acl-${normalizeEmail(Doc.CurrentUserEmail)}`; + var curUserPermission; + if (this.layoutDocAcls){ + if (targetDoc[DocAcl][userKey]) curUserPermission = HierarchyMapping.get(targetDoc[DocAcl][userKey])?.name; + else if (targetDoc['embedContainer']) curUserPermission = StrCast(Doc.GetProto(DocCast(targetDoc['embedContainer']))[userKey]); + else curUserPermission = StrCast(Doc.GetProto(targetDoc)?.[userKey]); + } + else curUserPermission = StrCast(targetDoc[userKey]); + // const curUserPermission = HierarchyMapping.get(effectiveAcls[0])!.name userListContents.unshift( sameAuthor ? (
@@ -593,7 +591,7 @@ export class SharingManager extends React.Component<{}> { Me
- {effectiveAcls.every(acl => acl === effectiveAcls[0]) ? concat(ReverseHierarchyMap.get(curUserPermission)?.image, ' ', curUserPermission) : '-multiple-'} + {effectiveAcls.every(acl => acl === effectiveAcls[0]) ? concat(ReverseHierarchyMap.get(curUserPermission!)?.image, ' ', curUserPermission) : '-multiple-'}  
@@ -613,22 +611,14 @@ export class SharingManager extends React.Component<{}> { let permissions = this.layoutDocAcls ? (targetDoc[DocAcl][groupKey] ? HierarchyMapping.get(targetDoc[DocAcl][groupKey])?.name : StrCast(Doc.GetProto(targetDoc)[groupKey])) : StrCast(targetDoc[groupKey]); if (this.layoutDocAcls){ if (groupKey == 'acl-Public') groupKey = 'acl-Public-layout'; - if (targetDoc[DocAcl][groupKey]){ - permissions = HierarchyMapping.get(targetDoc[DocAcl][groupKey])?.name; - } + if (targetDoc[DocAcl][groupKey]) permissions = HierarchyMapping.get(targetDoc[DocAcl][groupKey])?.name; else{ if (groupKey == 'acl-Public-layout') groupKey = 'acl-Public'; - if (targetDoc['embedContainer']){ - permissions = StrCast(Doc.GetProto(DocCast(targetDoc['embedContainer']))[groupKey]); - } - else{ - permissions = uniform ? StrCast(Doc.GetProto(targetDoc)?.[groupKey]) : '-multiple-'; - } + if (targetDoc['embedContainer']) permissions = StrCast(Doc.GetProto(DocCast(targetDoc['embedContainer']))[groupKey]); + else permissions = uniform ? StrCast(Doc.GetProto(targetDoc)?.[groupKey]) : '-multiple-'; } } - else{ - permissions = uniform ? StrCast(targetDoc?.[groupKey]) : '-multiple-'; - } + else permissions = uniform ? StrCast(targetDoc?.[groupKey]) : '-multiple-'; return !permissions ? null : (
@@ -710,7 +700,13 @@ export class SharingManager extends React.Component<{}> {
) : ( -
+
+
+
+ (this.layoutDocAcls = !this.layoutDocAcls))} checked={this.layoutDocAcls} /> +
+
+
)}
-- cgit v1.2.3-70-g09d2