From 17f53f604e0087615c2baff6cffa344771301b5e Mon Sep 17 00:00:00 2001
From: Sam Wilkins <abdullah_ahmed@brown.edu>
Date: Fri, 19 Jul 2019 13:49:37 -0400
Subject: fixed nto being able to edit when column menu flyout is closed bug

---
 .../views/collections/CollectionSchemaHeaders.tsx  | 39 +++++++++++-----------
 .../views/collections/CollectionSchemaView.tsx     | 16 ++++++---
 2 files changed, 31 insertions(+), 24 deletions(-)

(limited to 'src')

diff --git a/src/client/views/collections/CollectionSchemaHeaders.tsx b/src/client/views/collections/CollectionSchemaHeaders.tsx
index 6002d64ce..316b3f0ff 100644
--- a/src/client/views/collections/CollectionSchemaHeaders.tsx
+++ b/src/client/views/collections/CollectionSchemaHeaders.tsx
@@ -8,6 +8,7 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
 import { Flyout, anchorPoints } from "../DocumentDecorations";
 import { ColumnType } from "./CollectionSchemaView";
 import { emptyFunction } from "../../../Utils";
+import { contains } from "typescript-collections/dist/lib/arrays";
 
 library.add(faPlus, faFont, faHashtag, faAlignJustify, faCheckSquare, faToggleOn);
 
@@ -109,27 +110,25 @@ export interface ColumnMenuProps {
 @observer
 export class CollectionSchemaColumnMenu extends React.Component<ColumnMenuProps> {
     @observable private _isOpen: boolean = false;
-    // @observable private _node : HTMLDivElement | null = null;
-    @observable private _node = React.createRef<HTMLDivElement>();
+    @observable private _node : HTMLDivElement | null = null;
+    // @observable private _node = React.createRef<HTMLDivElement>();
+    @observable private _test = "test";
 
     componentDidMount() {
-        document.addEventListener("pointerdown", this.onPointerDown);
+        document.addEventListener("pointerdown", this.detectClick);
         console.log("did mount", this._node);
     }
 
     componentWillUnmount() {
-        document.removeEventListener("pointerdown", this.onPointerDown);
+        document.removeEventListener("pointerdown", this.detectClick);
     }
 
-    onPointerDown (e: PointerEvent) {
-        console.log("pointer down", this._node);
-        if (this._node ) {
-            // && this._node.contains(e.target as Node)
-            console.log("CLICKED INSNIDE");
+    detectClick = (e: PointerEvent): void => {
+        console.log("click", this);
+        if (this._node && this._node.contains(e.target as Node)) {
         } else {
-            console.log("CLICKED OUTSIDE");
-            // console.log(this._node);
-            // console.log(e.target as Node);
+            this._isOpen = false;
+            this.props.setIsEditing(false);
         }
     }
 
@@ -145,13 +144,13 @@ export class CollectionSchemaColumnMenu extends React.Component<ColumnMenuProps>
         this.props.setColumnType(this.props.keyValue, type);
     }
 
-    // @action
-    // setNode = (node: HTMLDivElement): void => {
-    //     if (node) {
-    //         this._node = node;
-    //         console.log("set node to ", this._node);
-    //     }
-    // }
+    @action
+    setNode = (node: HTMLDivElement): void => {
+        if (node) {
+            this._node = node;
+            console.log("set node to ", this._node);
+        }
+    }
 
     renderTypes = () => {
         if (this.props.typeConst) return <></>;
@@ -223,7 +222,7 @@ export class CollectionSchemaColumnMenu extends React.Component<ColumnMenuProps>
     render() {
         console.log("render", this._node);
         return (
-            <div className="collectionSchema-header-menu" ref={this._node}>
+            <div className="collectionSchema-header-menu" ref={this.setNode}>
                 <Flyout anchorPoint={anchorPoints.TOP_CENTER} content={this.renderContent()}>
                     <div className="collectionSchema-header-toggler" onClick={() => this.toggleIsOpen()}>{this.props.menuButtonContent}</div>
                 </ Flyout >
diff --git a/src/client/views/collections/CollectionSchemaView.tsx b/src/client/views/collections/CollectionSchemaView.tsx
index 10b1e895d..ffc9d7d09 100644
--- a/src/client/views/collections/CollectionSchemaView.tsx
+++ b/src/client/views/collections/CollectionSchemaView.tsx
@@ -480,10 +480,20 @@ export class CollectionSchemaView extends CollectionSubView(doc => doc) {
         this.previewScript = script;
     }
 
+    @computed
+    get schemaToolbar() {
+        return (
+            <div className="collectionSchemaView-toolbar">
+                <div id="preview-schema-checkbox-div"><input type="checkbox" key={"Show Preview"} checked={this.previewWidth() !== 0} onChange={this.toggleExpander} />Show Preview</div>
+            </div>
+        );
+    }
+
     render() {
         return (
             <div className="collectionSchemaView-container" onPointerDown={this.onPointerDown} onWheel={this.onWheel}
                 onDrop={(e: React.DragEvent) => this.onDrop(e, {})} onContextMenu={this.onContextMenu} ref={this.createTarget}>
+                {this.schemaToolbar}
                 {this.reactTable}
                 {this.dividerDragger}
                 {!this.previewWidth() ? (null) : this.previewPanel}
@@ -492,6 +502,8 @@ export class CollectionSchemaView extends CollectionSubView(doc => doc) {
         );
     }
 }
+
+
 interface CollectionSchemaPreviewProps {
     Document?: Doc;
     DataDocument?: Doc;
@@ -569,10 +581,6 @@ export class CollectionSchemaPreview extends React.Component<CollectionSchemaPre
 
     
     render() {
-
-            //                     <div id="preview-schema-checkbox-div"><input type="checkbox" key={"Show Preview"} checked={this.previewWidth() !== 0} onChange={this.toggleExpander} />  Show Preview </div>
-
-
         let input = this.props.previewScript === undefined ? (null) :
             <div ref={this.createTarget}><input className="collectionSchemaView-input" value={this.props.previewScript} onChange={this.onPreviewScriptChange}
                 style={{ left: `calc(50% - ${Math.min(75, (this.props.Document ? this.PanelWidth() / 2 : 75))}px)` }} /></div>;
-- 
cgit v1.2.3-70-g09d2