From 2009b5f46674e06932654b36e041de87621df001 Mon Sep 17 00:00:00 2001 From: Bob Zeleznik Date: Mon, 1 Jun 2020 19:56:55 -0400 Subject: fixed up suggestions for scriptingBox --- src/client/views/nodes/ScriptingBox.scss | 1 - src/client/views/nodes/ScriptingBox.tsx | 94 ++++++++++++++++---------------- 2 files changed, 46 insertions(+), 49 deletions(-) (limited to 'src') diff --git a/src/client/views/nodes/ScriptingBox.scss b/src/client/views/nodes/ScriptingBox.scss index 6113efbb5..14106dce2 100644 --- a/src/client/views/nodes/ScriptingBox.scss +++ b/src/client/views/nodes/ScriptingBox.scss @@ -26,7 +26,6 @@ .scriptingBox-textArea { flex: 70; - width: 70%; height: 100%; box-sizing: border-box; resize: none; diff --git a/src/client/views/nodes/ScriptingBox.tsx b/src/client/views/nodes/ScriptingBox.tsx index 72c92f00b..245081c47 100644 --- a/src/client/views/nodes/ScriptingBox.tsx +++ b/src/client/views/nodes/ScriptingBox.tsx @@ -1,4 +1,4 @@ -import { action, computed, observable } from "mobx"; +import { action, computed, observable, trace } from "mobx"; import { observer } from "mobx-react"; import * as React from "react"; import { Doc } from "../../../fields/Doc"; @@ -32,7 +32,6 @@ export class ScriptingBox extends ViewBoxAnnotatableComponent void; @@ -94,6 +93,7 @@ export class ScriptingBox extends ViewBoxAnnotatableComponent { - this._overlayDisposer?.(); - this._overlayDisposer = OverlayView.Instance.addElement(, { x: 0, y: 0 }); + // this._overlayDisposer?.(); + // this._overlayDisposer = OverlayView.Instance.addElement(, { x: 0, y: 0 }); } // sets field of the corresponding field key (param name) to be dropped document @@ -387,7 +387,7 @@ export class ScriptingBox extends ViewBoxAnnotatableComponent 0 ? "70%" : "100%" }}> + this._overlayDisposer?.()} + onChange={e => this.rawScript = e.target.value} + value={this.rawScript} + movePopupAsYouType={true} + loadingComponent={() => Loading} + + trigger={{ + "(": { + dataProvider: (token: any) => this.handleFunc(this.caretPos), + component: ({ entity: value }) =>
{value}
, + output: (item: any) => "(" + this.returnParam(item) + ")", + }, + " ": { + dataProvider: (token: any) => this.handleToken(token), + component: ({ entity: value }) => +
+
this.setHovered(true)} + onMouseLeave={() => this.setHovered(false)}> + {value} +
+ {!this._hovered ? (null) : + <> +
{this.getDescription(value)}
+
{this.getParams(value)}
+ + } +
, + output: (item: any, trigger) => trigger + item.trim(), + } + }} - return this._overlayDisposer?.()} - onChange={e => this.rawScript = e.target.value} - value={this.rawScript} - placeholder="write your script here" - className="ScriptingBox-textarea" - style={{ width: this.compileParams.length > 0 ? "70%" : "100%", resize: "none", height: "100%" }} - movePopupAsYouType={true} - loadingComponent={() => Loading} - - ref={(rta) => { this.rta = rta; }} - //innerRef={textarea => { this.rawScript = textarea.value; }} - - minChar={0} - - trigger={{ - " ": { - dataProvider: (token: any) => this.handleToken(token), - component: ({ entity: value }) => -
this.setHovered(true)} - onMouseLeave={() => this.setHovered(false)}> - {value} -
- {this._hovered ?
{this.getDescription(value)}
: (null)} - {this._hovered ?
{this.getParams(value)}
: (null)} -
- , - output: (item: any, trigger) => trigger + item.trim(), - }, - - "(": { - dataProvider: (token: any) => this.handleFunc(this.rta.getCaretPosition()), - component: ({ entity: value }) =>
{value}
, - output: (item: any) => "(" + this.returnParam(item) + ")", - } - - }} - - onCaretPositionChange={(number: any) => null} //this.handleKeyPress(number)} - />; + onCaretPositionChange={(number: any) => this.caretPos = number} + /> + ; } // inputs for scripting div (script box, params box, and params column) -- cgit v1.2.3-70-g09d2