From 529bd742842e76d1df464b13346fae4f22f8f3c9 Mon Sep 17 00:00:00 2001 From: Nathan-SR <144961007+Nathan-SR@users.noreply.github.com> Date: Sat, 10 May 2025 18:49:47 -0400 Subject: docpreviews resize (mostly) appropriately --- .../DataVizBox/DocCreatorMenu/DocCreatorMenu.scss | 8 +++ .../DataVizBox/DocCreatorMenu/DocCreatorMenu.tsx | 35 +++++---- .../DocCreatorMenu/Menu/TemplateEditingWindow.tsx | 38 +++++++--- .../DocCreatorMenu/Menu/TemplatePreviewBox.tsx | 84 ++++++++++++---------- .../Menu/TemplatesSidescrollDisplay.tsx | 7 -- 5 files changed, 106 insertions(+), 66 deletions(-) (limited to 'src') diff --git a/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.scss b/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.scss index 8f182d37f..277ca8238 100644 --- a/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.scss +++ b/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.scss @@ -230,6 +230,14 @@ &.full { width: 100%; } + + &.no-margin-bottom { + margin-bottom: 0px; + } + + &.no-margin-top { + margin-top: 0px; + } } //------------------------------------------------------------------------------------------------------------------------------------------ diff --git a/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.tsx b/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.tsx index 48fea91e2..b626fc70c 100644 --- a/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.tsx +++ b/src/client/views/nodes/DataVizBox/DocCreatorMenu/DocCreatorMenu.tsx @@ -89,7 +89,6 @@ export class DocCreatorMenu extends ObservableReactComponent static Instance: DocCreatorMenu; private DEBUG_MODE: boolean = true; - private _disposers: { [name: string]: IDisposer } = {}; private _ref: HTMLDivElement | null = null; private templateManager: TemplateManager; @@ -268,7 +267,6 @@ export class DocCreatorMenu extends ObservableReactComponent } componentWillUnmount() { - Object.values(this._disposers).forEach(disposer => disposer?.()); document.removeEventListener('pointerdown', this.onPointerDown, true); document.removeEventListener('pointerup', this.onPointerUp); } @@ -318,10 +316,10 @@ export class DocCreatorMenu extends ObservableReactComponent const { scale, refPt, transl } = this.getResizeVals(thisPt, dragHdl); !this._interactionLock && runInAction(async () => { // resize selected docs if we're not in the middle of a resize (ie, throttle input events to frame rate) - this._interactionLock = true; - const scaleAspect = {x: scale.x, y: scale.y}; - this.resizeView(refPt, scaleAspect, transl); // prettier-ignore - await new Promise(res => { setTimeout(() => { res(this._interactionLock = undefined)})}); + this._interactionLock = true; + const scaleAspect = {x: scale.x, y: scale.y}; + this.resizeView(refPt, scaleAspect, transl); // prettier-ignore + await new Promise(res => { setTimeout(() => { res(this._interactionLock = undefined)})}); }); // prettier-ignore return true; }; @@ -1065,12 +1063,25 @@ export class DocCreatorMenu extends ObservableReactComponent get renderSelectedViewType() { switch (this._menuContent) { case 'templates': - return + return ( +
+
+ +
+
+ +
+
+
+
+ ) case 'templateEditing': return + this._props.menu._resizing, + () => { this.forceUpdate() }, + { fireImmediately: true } + ); + } + + componentWillUnmount() { + Object.values(this._disposers).forEach(disposer => disposer?.()); + } + setContainerRef: React.LegacyRef = (node) => { this.previewWindow = node; + this.forceUpdate(); } @action setVariationTab = (open: boolean) => { @@ -78,15 +93,15 @@ export class TemplateEditingWindow extends ObservableReactComponent - this.previewWindow?.clientWidth ?? 1000 - 10} - PanelHeight={() => this.previewWindow?.clientHeight ?? 1000 - 60} - ScreenToLocalTransform={() => new Transform(-this._props.menu._pageX - 5, -this._props.menu._pageY - 35, 1)} + PanelWidth={() => this.previewWindow?.clientWidth ?? 500} + PanelHeight={() => this.previewWindow?.clientHeight ?? 500} + ScreenToLocalTransform={() => new Transform(/*-this._props.menu._pageX - 5, -this._props.menu._pageY - 35*/0, 0, 1)} renderDepth={5} whenChildContentsActiveChanged={emptyFunction} focus={emptyFunction} @@ -98,18 +113,19 @@ export class TemplateEditingWindow extends ObservableReactComponent + /> : null} ) } render() { return ( -
+
-
+
{this.renderedDocPreview} - {this.fireflyVariationsTab} +
+ {this._variationsTabOpen ? this.fireflyVariationsTab : null}
diff --git a/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatePreviewBox.tsx b/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatePreviewBox.tsx index 4759a4158..e63be8f9c 100644 --- a/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatePreviewBox.tsx +++ b/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatePreviewBox.tsx @@ -1,7 +1,7 @@ import { Colors } from "@dash/components/src"; import { FontAwesomeIcon, FontAwesomeIconProps } from "@fortawesome/react-fontawesome"; import { Template } from "../Template"; -import { runInAction } from "mobx"; +import { reaction, runInAction } from "mobx"; import React from "react"; import { ObservableReactComponent } from "../../../../ObservableReactComponent"; import { DocCreatorMenu } from "../DocCreatorMenu"; @@ -12,6 +12,7 @@ import { returnEmptyFilter, returnFalse } from "../../../../../../ClientUtils"; import { Transform } from "../../../../../util/Transform"; import { DefaultStyleProvider } from "../../../../StyleProvider"; import { returnEmptyDoclist } from "../../../../../../fields/Doc"; +import { IDisposer } from "mobx-utils"; export interface TemplatePreviewBoxProps { template: Template; @@ -22,6 +23,13 @@ export interface TemplatePreviewBoxProps { export class TemplatePreviewBox extends ObservableReactComponent { + private previewWindow: HTMLDivElement | null = null; + + setContainerRef: React.LegacyRef = (node) => { + this.previewWindow = node; + this.forceUpdate(); + } + render() { const template = this.props.template; @@ -29,46 +37,48 @@ export class TemplatePreviewBox extends ObservableReactComponent this.props.menu.setUpButtonClick(e, () => runInAction(() => {console.log('setting'); this.props.menu._selectedTemplate = template}))}> - { this.props.leftButtonOpts ? - : null - } - { this.props.rightButtonOpts ? - : null } - this.props.menu._menuDimensions.height * .3} - PanelHeight={() => this.props.menu._menuDimensions.height * .3} - ScreenToLocalTransform={() => new Transform(-this.props.menu._pageX - 5, -this.props.menu._pageY - 35, 1)} - renderDepth={1} - whenChildContentsActiveChanged={emptyFunction} - focus={emptyFunction} - styleProvider={DefaultStyleProvider} - addDocTab={this.props.menu._props.addDocTab} - pinToPres={() => undefined} - childFilters={returnEmptyFilter} - childFiltersByRanges={returnEmptyFilter} - searchFilterDocs={returnEmptyDoclist} - fitContentsToBox={returnFalse} - fitWidth={returnFalse} - hideDecorations={true} - /> + onPointerDown={e => this.props.menu.setUpButtonClick(e, () => runInAction(() => {console.log('setting'); this.props.menu._selectedTemplate = template}))} + > + { this.props.leftButtonOpts ? + : null + } + { this.props.rightButtonOpts ? + : null } + this.previewWindow?.clientWidth ?? this.props.menu._menuDimensions.height * .3} + PanelHeight={() => this.previewWindow?.clientHeight ?? this.props.menu._menuDimensions.height * .3} + ScreenToLocalTransform={() => new Transform(-this.props.menu._pageX - 5, -this.props.menu._pageY - 35, 1)} + renderDepth={1} + whenChildContentsActiveChanged={emptyFunction} + focus={emptyFunction} + styleProvider={DefaultStyleProvider} + addDocTab={this.props.menu._props.addDocTab} + pinToPres={() => undefined} + childFilters={returnEmptyFilter} + childFiltersByRanges={returnEmptyFilter} + searchFilterDocs={returnEmptyDoclist} + fitContentsToBox={returnFalse} + fitWidth={returnFalse} + hideDecorations={true} + />
) } diff --git a/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatesSidescrollDisplay.tsx b/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatesSidescrollDisplay.tsx index a5f96ef90..1f6eed9e5 100644 --- a/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatesSidescrollDisplay.tsx +++ b/src/client/views/nodes/DataVizBox/DocCreatorMenu/Menu/TemplatesSidescrollDisplay.tsx @@ -44,13 +44,6 @@ export class TemplateSidescrollView extends ObservableReactComponent ))}
-
-
- -
-
); } -- cgit v1.2.3-70-g09d2