From 9bc4d40220bb5bf0b976d5f425457813f6b9981b Mon Sep 17 00:00:00 2001 From: bobzel Date: Fri, 19 Mar 2021 14:19:05 -0400 Subject: fixed double clicking on text to select text unless near the border. Also allos clicking to set insertion point on isLInkButton text boxes that have been selected. --- src/client/views/nodes/formattedText/FormattedTextBox.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/client/views/nodes/formattedText/FormattedTextBox.tsx b/src/client/views/nodes/formattedText/FormattedTextBox.tsx index f6fa41145..e83891e42 100644 --- a/src/client/views/nodes/formattedText/FormattedTextBox.tsx +++ b/src/client/views/nodes/formattedText/FormattedTextBox.tsx @@ -1250,10 +1250,10 @@ export class FormattedTextBox extends ViewBoxAnnotatableComponent<(FieldViewProp e.stopPropagation(); return; } - this.props.isSelected(true) && ((e.nativeEvent as any).formattedHandled = true); - if (this.props.isSelected(true)) { // if text box is selected, then it consumes all click events - // e.stopPropagation(); // bcz: not sure why this was here. We need to allow the DocumentView to get clicks to process doubleClicks + (e.nativeEvent as any).formattedHandled = true + if (this.ProseRef?.children[0] !== e.nativeEvent.target) e.stopPropagation(); // if you double click on text, then it will be selected instead of sending a double click to DocumentView & opening a lightbox. Also,if a text box has isLinkButton, this will prevent link following if you've selected the document to edit it. + // e.stopPropagation(); // bcz: not sure why this was here. We need to allow the DocumentView to get clicks to process doubleClicks (see above comment) this.hitBulletTargets(e.clientX, e.clientY, !this._editorView?.state.selection.empty || this._forceUncollapse, false, this._forceDownNode, e.shiftKey); } this._forceUncollapse = !(this._editorView!.root as any).getSelection().isCollapsed; -- cgit v1.2.3-70-g09d2