From cc5294616936c5e8a3a09f51fba4e6e89ce2c26c Mon Sep 17 00:00:00 2001 From: bobzel Date: Fri, 1 Oct 2021 11:30:45 -0400 Subject: fixed keyboard delete of ink control points to never delete the stroke. --- src/client/views/InkControlPtHandles.tsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/client/views/InkControlPtHandles.tsx b/src/client/views/InkControlPtHandles.tsx index 94c238b2b..0644488b3 100644 --- a/src/client/views/InkControlPtHandles.tsx +++ b/src/client/views/InkControlPtHandles.tsx @@ -28,6 +28,13 @@ export class InkControlPtHandles extends React.Component { @observable private _overControl = -1; @observable controlUndo: UndoManager.Batch | undefined; + + componentDidMount() { + document.addEventListener("keydown", this.onDelete, true); + } + componentWillUnmount() { + document.removeEventListener("keydown", this.onDelete, true); + } /** * Handles the movement of a selected control point when the user clicks and drags. * @param controlIndex The index of the currently selected control point. @@ -91,7 +98,8 @@ export class InkControlPtHandles extends React.Component { @action onDelete = (e: KeyboardEvent) => { if (["-", "Backspace", "Delete"].includes(e.key)) { - if (InkStrokeProperties.Instance?.deletePoints()) e.stopPropagation(); + InkStrokeProperties.Instance?.deletePoints(); + e.stopPropagation(); } } @@ -102,7 +110,6 @@ export class InkControlPtHandles extends React.Component { changeCurrPoint = (i: number) => { if (InkStrokeProperties.Instance) { InkStrokeProperties.Instance._currentPoint = i; - document.addEventListener("keydown", this.onDelete, true); } } -- cgit v1.2.3-70-g09d2