From eebe58b47acfe3b13c22407b98763cdbd6e1eb58 Mon Sep 17 00:00:00 2001 From: Tyler Schicke Date: Thu, 2 May 2019 01:31:03 -0400 Subject: "Fixed" proto access issue This is actually cause by import order, which I didn't really fix yet but which needs to be fixed --- src/client/views/nodes/DocumentView.tsx | 4 +--- src/new_fields/Doc.ts | 5 +++-- src/new_fields/List.ts | 2 +- src/new_fields/Schema.ts | 2 +- src/new_fields/Types.ts | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/client/views/nodes/DocumentView.tsx b/src/client/views/nodes/DocumentView.tsx index b35d68c4b..f58dc4a02 100644 --- a/src/client/views/nodes/DocumentView.tsx +++ b/src/client/views/nodes/DocumentView.tsx @@ -198,9 +198,7 @@ export class DocumentView extends DocComponent(Docu CollectionDockingView.Instance.AddRightSplit(kvp); } fullScreenClicked = (e: React.MouseEvent): void => { - const doc = Doc.MakeDelegate(FieldValue(this.props.Document.proto)); - // bcz .. should this work? - // const doc = Doc.MakeDelegate(FieldValue(this.Document.proto)); + const doc = Doc.MakeDelegate(FieldValue(this.Document.proto)); if (doc) { CollectionDockingView.Instance.OpenFullScreen(doc); } diff --git a/src/new_fields/Doc.ts b/src/new_fields/Doc.ts index 6162b3c76..8dd293f2d 100644 --- a/src/new_fields/Doc.ts +++ b/src/new_fields/Doc.ts @@ -9,7 +9,7 @@ import { listSpec } from "./Schema"; import { List } from "./List"; import { ObjectField, Parent, OnUpdate } from "./ObjectField"; import { RefField, FieldId, Id, HandleUpdate } from "./RefField"; -import { Docs } from "../client/documents/Documents"; +// import { Docs } from "../client/documents/Documents"; export function IsField(field: any): field is Field { return (typeof field === "string") @@ -183,7 +183,8 @@ export namespace Doc { export function MakeLink(source: Doc, target: Doc) { UndoManager.RunInBatch(() => { - let linkDoc = Docs.TextDocument({ width: 100, height: 30, borderRounding: -1 }); + // let linkDoc = Docs.TextDocument({ width: 100, height: 30, borderRounding: -1 }); + let linkDoc = new Doc; linkDoc.title = "-link name-"; linkDoc.linkDescription = ""; linkDoc.linkTags = "Default"; diff --git a/src/new_fields/List.ts b/src/new_fields/List.ts index ff10a3f73..1c4b96c81 100644 --- a/src/new_fields/List.ts +++ b/src/new_fields/List.ts @@ -2,7 +2,7 @@ import { Deserializable, autoObject } from "../client/util/SerializationHelper"; import { Field, Update, Self, FieldResult } from "./Doc"; import { setter, getter, deleteProperty } from "./util"; import { serializable, alias, list } from "serializr"; -import { observable, observe, IArrayChange, IArraySplice, IObservableArray, Lambda, reaction } from "mobx"; +import { observable } from "mobx"; import { ObjectField, OnUpdate, Copy } from "./ObjectField"; import { RefField } from "./RefField"; import { ProxyField } from "./Proxy"; diff --git a/src/new_fields/Schema.ts b/src/new_fields/Schema.ts index 7444878fe..b821baec9 100644 --- a/src/new_fields/Schema.ts +++ b/src/new_fields/Schema.ts @@ -10,7 +10,7 @@ export const emptySchema = createSchema({}); export const Document = makeInterface(emptySchema); export type Document = makeInterface<[typeof emptySchema]>; -export type makeInterface = Partial> & Doc; +export type makeInterface = Partial> & Doc & { proto: Doc | undefined }; // export function makeInterface(schemas: T): (doc: U) => All; // export function makeInterface(schema: T): (doc: U) => makeInterface; export function makeInterface(...schemas: T): (doc?: Doc) => makeInterface { diff --git a/src/new_fields/Types.ts b/src/new_fields/Types.ts index e179c2602..60f08dc90 100644 --- a/src/new_fields/Types.ts +++ b/src/new_fields/Types.ts @@ -18,7 +18,7 @@ export type ToConstructor = new (...args: any[]) => T; export type ToInterface = { - [P in keyof T]: FieldResult>; + [P in Exclude]: FieldResult>; }; // type ListSpec = { List: ToContructor> | ListSpec> }; -- cgit v1.2.3-70-g09d2