From b499035b1287ce12fc57f272c3c208295a6e16be Mon Sep 17 00:00:00 2001 From: Ivan Chen Date: Mon, 17 May 2021 14:34:02 -0400 Subject: Update pr template --- .github/pull_request_template.md | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b39e49be..6d068539 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,30 +7,24 @@ ## Description -## Packages added (using `yarn add` or `yarn add --dev`) - -- **package-name** — Use case of package within project - ## How Has This Been Tested? +- [ ] Requires testing on different screen sizes (iPhone 8, iPhone 11) (optional) +- [ ] Requires testing on different screen sizes (iPhone 12 mini, iPhone 12 Pro Max) (optional) ## Screenshots (if appropriate) -## Types of changes - -- [ ] Bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to change) -- [ ] Documentation/repository update + + + ## Checklist - [ ] I thoroughly tested my changes and ensured that they integrate with existing functionality. -- [ ] I ran `yarn lint` and `yarn type`, and I fixed any syntax or type errors that came up. - [ ] I ran `git pull --rebase upstream master` in my branch and resolved any merge conflicts on my end. -- [ ] I clearly documented and detailed my code where I deemed it necessary to do so. +- [ ] I documented my code in line with our [style guide](https://taggid.atlassian.net/wiki/spaces/~523670961/pages/891944961). - [ ] My changes require a change to the documentation... - [ ] ... which I have updated accordingly. -- cgit v1.2.3-70-g09d2