From f399478fb2fe460ead185b0da7769faed8a8c515 Mon Sep 17 00:00:00 2001 From: Shravya Ramesh Date: Fri, 12 Mar 2021 08:42:46 -0800 Subject: done --- src/components/profile/ProfileMoreInfoDrawer.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/components/profile') diff --git a/src/components/profile/ProfileMoreInfoDrawer.tsx b/src/components/profile/ProfileMoreInfoDrawer.tsx index 90f5da48..d8f91abe 100644 --- a/src/components/profile/ProfileMoreInfoDrawer.tsx +++ b/src/components/profile/ProfileMoreInfoDrawer.tsx @@ -42,7 +42,11 @@ const ProfileMoreInfoDrawer: React.FC = (props) => { if (suggested_people_linked === 0) { Alert.alert(ERROR_ATTEMPT_EDIT_SP); } else { - navigation.push('UpdateSPPicture'); + // Sending undefined for updatedSelectedBadges to mark that there was no update yet + navigation.push('UpdateSPPicture', { + editing: true, + updatedSelectedBadges: undefined, + }); setIsOpen(false); } }; -- cgit v1.2.3-70-g09d2 From b34da6e2d3f78a3d846665ded5d5a0c508873c6c Mon Sep 17 00:00:00 2001 From: Shravya Ramesh Date: Fri, 12 Mar 2021 11:11:10 -0800 Subject: comments, removed unused code --- src/components/profile/ProfileMoreInfoDrawer.tsx | 1 - src/routes/main/MainStackNavigator.tsx | 1 - src/screens/badge/BadgeSelection.tsx | 2 +- .../suggestedPeopleOnboarding/SuggestedPeopleUploadPictureScreen.tsx | 1 + 4 files changed, 2 insertions(+), 3 deletions(-) (limited to 'src/components/profile') diff --git a/src/components/profile/ProfileMoreInfoDrawer.tsx b/src/components/profile/ProfileMoreInfoDrawer.tsx index d8f91abe..2fec5cca 100644 --- a/src/components/profile/ProfileMoreInfoDrawer.tsx +++ b/src/components/profile/ProfileMoreInfoDrawer.tsx @@ -45,7 +45,6 @@ const ProfileMoreInfoDrawer: React.FC = (props) => { // Sending undefined for updatedSelectedBadges to mark that there was no update yet navigation.push('UpdateSPPicture', { editing: true, - updatedSelectedBadges: undefined, }); setIsOpen(false); } diff --git a/src/routes/main/MainStackNavigator.tsx b/src/routes/main/MainStackNavigator.tsx index fea375f6..c60c8602 100644 --- a/src/routes/main/MainStackNavigator.tsx +++ b/src/routes/main/MainStackNavigator.tsx @@ -77,7 +77,6 @@ export type MainStackParams = { }; UpdateSPPicture: { editing: boolean; - updatedSelectedBadges: string[] | undefined; }; BadgeSelection: { editing: boolean; diff --git a/src/screens/badge/BadgeSelection.tsx b/src/screens/badge/BadgeSelection.tsx index 755bb581..e8a060ee 100644 --- a/src/screens/badge/BadgeSelection.tsx +++ b/src/screens/badge/BadgeSelection.tsx @@ -40,6 +40,7 @@ const BadgeSelection: React.FC = ({route}) => { const dispatch = useDispatch(); const navigation = useNavigation(); + // Loading badges data and extracting into a string [] useEffect(() => { const loadData = async () => { const response = await getSuggestedPeopleProfile(loggedInUserId); @@ -64,7 +65,6 @@ const BadgeSelection: React.FC = ({route}) => { updateBadgesService(selectedBadges); navigation.navigate('UpdateSPPicture', { editing: true, - updatedSelectedBadges: selectedBadges, }); } else { if (selectedBadges.length !== 0) { diff --git a/src/screens/suggestedPeopleOnboarding/SuggestedPeopleUploadPictureScreen.tsx b/src/screens/suggestedPeopleOnboarding/SuggestedPeopleUploadPictureScreen.tsx index 74034287..0c34e90c 100644 --- a/src/screens/suggestedPeopleOnboarding/SuggestedPeopleUploadPictureScreen.tsx +++ b/src/screens/suggestedPeopleOnboarding/SuggestedPeopleUploadPictureScreen.tsx @@ -87,6 +87,7 @@ const SuggestedPeopleUploadPictureScreen: React.FC { + // Uploading image only if initially loaded image is not the same as the image being uploaded if (image && oldImage !== image) { setLoading(true); const success = await sendSuggestedPeoplePhoto(image); -- cgit v1.2.3-70-g09d2