diff options
author | Julia McCauley <skurvyj@gmail.com> | 2021-04-16 18:35:34 -0400 |
---|---|---|
committer | Julia McCauley <skurvyj@gmail.com> | 2021-04-16 18:35:34 -0400 |
commit | 2b49d7ba79e8a26a0abe3e0e16ad72f103072ac1 (patch) | |
tree | 8f4c54d1fb975e7f9bbc641dcca0c9232a0fb220 | |
parent | 7cf6c2b08add62df693a9a2e2c1ee0ed6f0c5aee (diff) |
added some todos
4 files changed, 12 insertions, 0 deletions
diff --git a/src/main/java/edu/brown/cs/student/term/Main.java b/src/main/java/edu/brown/cs/student/term/Main.java index 1c9b1f7..41fd61d 100644 --- a/src/main/java/edu/brown/cs/student/term/Main.java +++ b/src/main/java/edu/brown/cs/student/term/Main.java @@ -133,6 +133,7 @@ public final class Main { return "OK"; }); Spark.before((request, response) -> response.header("Access-Control-Allow-Origin", "*")); + //TODO: Add system testing for all of our end points Spark.post("/data", new SuspicionRankHandler()); Spark.post("/profit", new ProfitQueryHandler()); Spark.post("/trade-lookup", new TradeQueryHandler()); diff --git a/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java b/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java index 74628aa..fbe05f7 100644 --- a/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java +++ b/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java @@ -38,6 +38,12 @@ public class SuspicionRanker { } } + /** + * + * @param start + * @param end + * @return + */ public List<Holder> getSuspicionScoreList(Instant start, Instant end) { PriorityQueue<Holder> orderedSuspicion = new PriorityQueue<>(new SuspicionComparator()); List<Holder> suspicionList = new ArrayList<>(); diff --git a/src/test/java/edu/brown/cs/student/HubRankTest.java b/src/test/java/edu/brown/cs/student/HubRankTest.java index 07fd282..cbef9ee 100644 --- a/src/test/java/edu/brown/cs/student/HubRankTest.java +++ b/src/test/java/edu/brown/cs/student/HubRankTest.java @@ -126,4 +126,6 @@ public class HubRankTest { tearDown(); } + + //TODO: Test special case where all the hub ranks should be the same } diff --git a/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java b/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java index 3f8ea3d..e004e46 100644 --- a/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java +++ b/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java @@ -82,6 +82,9 @@ public class SuspicionRankerTest { tearDown(); } + //TODO: Test special case for all the profit = 0 + //TODO: Test special case for all the profit is negative + } |