Finally have an xml parser that reads the urls and inserts data into database consistently. A couple functionality todos, then need to do some more edge testing.

2 files changed, 14 insertions, 1 deletions

diff --git a/src/test/java/edu/brown/cs/student/TransactionTest.java b/src/test/java/edu/brown/cs/student/TransactionTest.java
index e8b95bc..faf24fb 100644
--- a/src/test/java/edu/brown/cs/student/TransactionTest.java
+++ b/src/test/java/edu/brown/cs/student/TransactionTest.java
@@ -95,4 +95,13 @@ public class TransactionTest {
     tearDown();
   }
 
+  @Test
+  public void badFormats(){
+    setUp();
+    // TODO: ensure 0 price trades aren't there, market trades aren't there, .00 on end of ints, etc...
+    // no price -> https://www.sec.gov/Archives/edgar/data/1654595/000110465921048974/tm2112683-1_4seq1.xml
+    // market form -> https://www.sec.gov/Archives/edgar/data/39899/000121465921004094/marketforms-52237.xml
+    tearDown();
+  }
+
 }
diff --git a/src/test/java/edu/brown/cs/student/XmlParserTest.java b/src/test/java/edu/brown/cs/student/XmlParserTest.java
index e6a112f..eebccbb 100644
--- a/src/test/java/edu/brown/cs/student/XmlParserTest.java
+++ b/src/test/java/edu/brown/cs/student/XmlParserTest.java
@@ -48,9 +48,13 @@ public class XmlParserTest {
     Document doc =
         _urlXmlParser.parse("https://www.sec.gov/Archives/edgar/data/1517006/000110465921046242/tm2112036-4_4seq1.xml");
     assertNotNull(doc);
-
     // Id of person
     assertEquals(getIdFromDoc(doc), "0001561844");
+
+    Document doc2 =
+        _urlXmlParser.parse("https://www.sec.gov/Archives/edgar/data/1254015/000120919121026318/doc4.xml");
+    assertNotNull(doc2);
+    assertEquals(getIdFromDoc(doc2), "0001254015");
     tearDown();
   }