From 2b49d7ba79e8a26a0abe3e0e16ad72f103072ac1 Mon Sep 17 00:00:00 2001 From: Julia McCauley Date: Fri, 16 Apr 2021 18:35:34 -0400 Subject: added some todos --- src/main/java/edu/brown/cs/student/term/Main.java | 1 + src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java | 6 ++++++ src/test/java/edu/brown/cs/student/HubRankTest.java | 2 ++ src/test/java/edu/brown/cs/student/SuspicionRankerTest.java | 3 +++ 4 files changed, 12 insertions(+) (limited to 'src') diff --git a/src/main/java/edu/brown/cs/student/term/Main.java b/src/main/java/edu/brown/cs/student/term/Main.java index 1c9b1f7..41fd61d 100644 --- a/src/main/java/edu/brown/cs/student/term/Main.java +++ b/src/main/java/edu/brown/cs/student/term/Main.java @@ -133,6 +133,7 @@ public final class Main { return "OK"; }); Spark.before((request, response) -> response.header("Access-Control-Allow-Origin", "*")); + //TODO: Add system testing for all of our end points Spark.post("/data", new SuspicionRankHandler()); Spark.post("/profit", new ProfitQueryHandler()); Spark.post("/trade-lookup", new TradeQueryHandler()); diff --git a/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java b/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java index 74628aa..fbe05f7 100644 --- a/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java +++ b/src/main/java/edu/brown/cs/student/term/hub/SuspicionRanker.java @@ -38,6 +38,12 @@ public class SuspicionRanker { } } + /** + * + * @param start + * @param end + * @return + */ public List getSuspicionScoreList(Instant start, Instant end) { PriorityQueue orderedSuspicion = new PriorityQueue<>(new SuspicionComparator()); List suspicionList = new ArrayList<>(); diff --git a/src/test/java/edu/brown/cs/student/HubRankTest.java b/src/test/java/edu/brown/cs/student/HubRankTest.java index 07fd282..cbef9ee 100644 --- a/src/test/java/edu/brown/cs/student/HubRankTest.java +++ b/src/test/java/edu/brown/cs/student/HubRankTest.java @@ -126,4 +126,6 @@ public class HubRankTest { tearDown(); } + + //TODO: Test special case where all the hub ranks should be the same } diff --git a/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java b/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java index 3f8ea3d..e004e46 100644 --- a/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java +++ b/src/test/java/edu/brown/cs/student/SuspicionRankerTest.java @@ -82,6 +82,9 @@ public class SuspicionRankerTest { tearDown(); } + //TODO: Test special case for all the profit = 0 + //TODO: Test special case for all the profit is negative + } -- cgit v1.2.3-70-g09d2