diff options
author | bobzel <zzzman@gmail.com> | 2021-04-15 00:20:57 -0400 |
---|---|---|
committer | bobzel <zzzman@gmail.com> | 2021-04-15 00:20:57 -0400 |
commit | 70f92c85461dc50fb0e63d3ecd5c429bcae37cc7 (patch) | |
tree | 03359eb84dc8be43e37d80396014ee18586a5229 | |
parent | 4334a553fdfdf44b1d1c609290fe2a874a408967 (diff) |
simplified carousel DocumentView calls.
-rw-r--r-- | src/client/views/collections/CollectionCarousel3DView.tsx | 35 | ||||
-rw-r--r-- | src/client/views/collections/CollectionCarouselView.tsx | 33 |
2 files changed, 13 insertions, 55 deletions
diff --git a/src/client/views/collections/CollectionCarousel3DView.tsx b/src/client/views/collections/CollectionCarousel3DView.tsx index 7cebabaa9..2251b60e5 100644 --- a/src/client/views/collections/CollectionCarousel3DView.tsx +++ b/src/client/views/collections/CollectionCarousel3DView.tsx @@ -9,7 +9,7 @@ import { makeInterface } from '../../../fields/Schema'; import { ScriptField } from '../../../fields/ScriptField'; import { NumCast, ScriptCast, StrCast } from '../../../fields/Types'; import { OmitKeys, returnFalse, Utils } from '../../../Utils'; -import { DragManager, dropActionType } from '../../util/DragManager'; +import { DragManager } from '../../util/DragManager'; import { DocumentView } from '../nodes/DocumentView'; import "./CollectionCarousel3DView.scss"; import { CollectionSubView } from './CollectionSubView'; @@ -41,38 +41,15 @@ export class CollectionCarousel3DView extends CollectionSubView(Carousel3DDocume @computed get content() { const currentIndex = NumCast(this.layoutDoc._itemIndex); const displayDoc = (childPair: { layout: Doc, data: Doc }) => { - const script = ScriptField.MakeScript("this._showCaption = 'caption'", { this: Doc.name }); - const onChildClick = script && (() => script); - return <DocumentView - Document={childPair.layout} - DataDoc={childPair.layout.resolvedDataDoc as Doc} - styleProvider={this.props.styleProvider} - layerProvider={this.props.layerProvider} - docViewPath={this.props.docViewPath} + return <DocumentView {...OmitKeys(this.props, ["NativeWidth", "NativeHeight", "childLayoutTemplate", "childLayoutString"]).omit} + onDoubleClick={this.onChildDoubleClick} + renderDepth={this.props.renderDepth + 1} LayoutTemplate={this.props.childLayoutTemplate} LayoutTemplateString={this.props.childLayoutString} - freezeDimensions={this.props.childFreezeDimensions} - renderDepth={this.props.renderDepth + 1} + Document={childPair.layout} + DataDoc={childPair.data} PanelWidth={this.panelWidth} PanelHeight={this.panelHeight} - rootSelected={this.rootSelected} - dropAction={StrCast(this.props.Document.childDropAction) as dropActionType} - ScreenToLocalTransform={this.props.ScreenToLocalTransform} - focus={this.props.focus} - docFilters={this.docFilters} - onDoubleClick={this.onChildDoubleClick} - onClick={onChildClick} - isContentActive={returnFalse} - docRangeFilters={this.docRangeFilters} - searchFilterDocs={this.searchFilterDocs} - ContainingCollectionDoc={this.props.CollectionView?.props.Document} - ContainingCollectionView={this.props.CollectionView} - addDocument={this.props.addDocument} - moveDocument={this.props.moveDocument} - removeDocument={this.props.removeDocument} - whenChildContentsActiveChanged={this.props.whenChildContentsActiveChanged} - addDocTab={this.props.addDocTab} - pinToPres={this.props.pinToPres} bringToFront={returnFalse} />; }; diff --git a/src/client/views/collections/CollectionCarouselView.tsx b/src/client/views/collections/CollectionCarouselView.tsx index 4a7bdf6db..d28a4d87d 100644 --- a/src/client/views/collections/CollectionCarouselView.tsx +++ b/src/client/views/collections/CollectionCarouselView.tsx @@ -7,7 +7,7 @@ import { collectionSchema, documentSchema } from '../../../fields/documentSchema import { makeInterface } from '../../../fields/Schema'; import { NumCast, ScriptCast, StrCast } from '../../../fields/Types'; import { OmitKeys, returnFalse } from '../../../Utils'; -import { DragManager, dropActionType } from '../../util/DragManager'; +import { DragManager } from '../../util/DragManager'; import { DocumentView } from '../nodes/DocumentView'; import { FormattedTextBox } from '../nodes/formattedText/FormattedTextBox'; import { StyleProp } from '../StyleProvider'; @@ -47,34 +47,15 @@ export class CollectionCarouselView extends CollectionSubView(CarouselDocument) return !(curDoc?.layout instanceof Doc) ? (null) : <> <div className="collectionCarouselView-image" key="image"> - <DocumentView - Document={curDoc.layout} - DataDoc={curDoc.layout.resolvedDataDoc as Doc} - styleProvider={this.props.styleProvider} - layerProvider={this.props.layerProvider} - docViewPath={this.props.docViewPath} + <DocumentView {...OmitKeys(this.props, ["NativeWidth", "NativeHeight", "childLayoutTemplate", "childLayoutString"]).omit} + onDoubleClick={this.onContentDoubleClick} + onClick={this.onContentClick} + renderDepth={this.props.renderDepth + 1} LayoutTemplate={this.props.childLayoutTemplate} LayoutTemplateString={this.props.childLayoutString} - freezeDimensions={this.props.childFreezeDimensions} - renderDepth={this.props.renderDepth + 1} - PanelWidth={this.props.PanelWidth} + Document={curDoc.layout} + DataDoc={curDoc.layout.resolvedDataDoc as Doc} PanelHeight={this.panelHeight} - rootSelected={this.rootSelected} - dropAction={StrCast(this.props.Document.childDropAction) as dropActionType} - ScreenToLocalTransform={this.props.ScreenToLocalTransform} - focus={this.props.focus} - docFilters={this.docFilters} - isContentActive={returnFalse} - docRangeFilters={this.docRangeFilters} - searchFilterDocs={this.searchFilterDocs} - ContainingCollectionDoc={this.props.CollectionView?.props.Document} - ContainingCollectionView={this.props.CollectionView} - addDocument={this.props.addDocument} - moveDocument={this.props.moveDocument} - removeDocument={this.props.removeDocument} - whenChildContentsActiveChanged={this.props.whenChildContentsActiveChanged} - addDocTab={this.props.addDocTab} - pinToPres={this.props.pinToPres} bringToFront={returnFalse} /> </div> |