fixed warnings

4 files changed, 13 insertions, 13 deletions

diff --git a/src/client/documents/Documents.ts b/src/client/documents/Documents.ts
index 159771145..45c465d84 100644
--- a/src/client/documents/Documents.ts
+++ b/src/client/documents/Documents.ts
@@ -895,8 +895,8 @@ export namespace Docs {
 export namespace DocUtils {
     export function Excluded(d: Doc, docFilters: string[]) {
         const filterFacets: { [key: string]: { [value: string]: string } } = {};  // maps each filter key to an object with value=>modifier fields
-        for (let i = 0; i < docFilters.length; i++) {
-            const fields = docFilters[i].split(":");
+        docFilters.forEach(filter => {
+            const fields = filter.split(":");
             const key = fields[0];
             const value = fields[1];
             const modifiers = fields[2];
@@ -904,7 +904,7 @@ export namespace DocUtils {
                 filterFacets[key] = {};
             }
             filterFacets[key][value] = modifiers;
-        }
+        });
 
         if (d.z) return false;
         for (const facetKey of Object.keys(filterFacets)) {
@@ -921,8 +921,8 @@ export namespace DocUtils {
         const childDocs = viewSpecScript ? docs.filter(d => viewSpecScript.script.run({ doc: d }, console.log).result) : docs;
 
         const filterFacets: { [key: string]: { [value: string]: string } } = {};  // maps each filter key to an object with value=>modifier fields
-        for (let i = 0; i < docFilters.length; i++) {
-            const fields = docFilters[i].split(":");
+        docFilters.forEach(filter => {
+            const fields = filter.split(":");
             const key = fields[0];
             const value = fields[1];
             const modifiers = fields[2];
@@ -930,7 +930,7 @@ export namespace DocUtils {
                 filterFacets[key] = {};
             }
             filterFacets[key][value] = modifiers;
-        }
+        });
 
         const filteredDocs = docFilters.length ? childDocs.filter(d => {
             if (d.z) return true;
diff --git a/src/client/util/SharingManager.tsx b/src/client/util/SharingManager.tsx
index 914253e3c..0cd5332ca 100644
--- a/src/client/util/SharingManager.tsx
+++ b/src/client/util/SharingManager.tsx
@@ -140,9 +140,9 @@ export class SharingManager extends React.Component<{}> {
             });
             return Promise.all(evaluating).then(() => {
                 runInAction(() => {
-                    for (let i = 0; i < sharingDocs.length; i++) {
-                        if (!this.users.find(user => user.user.email === sharingDocs[i].user.email)) {
-                            this.users.push(sharingDocs[i]);
+                    for (let sharer of sharingDocs) {
+                        if (!this.users.find(user => user.user.email === sharer.user.email)) {
+                            this.users.push(sharer);
                         }
                     }
                 });
diff --git a/src/client/views/nodes/FilterBox.tsx b/src/client/views/nodes/FilterBox.tsx
index 0d02a4388..bb20f91c0 100644
--- a/src/client/views/nodes/FilterBox.tsx
+++ b/src/client/views/nodes/FilterBox.tsx
@@ -224,8 +224,8 @@ export class FilterBox extends ViewBoxBaseComponent<FieldViewProps, FilterBoxDoc
 
 Scripting.addGlobal(function determineCheckedState(layoutDoc: Doc, facetHeader: string, facetValue: string) {
     const docFilters = Cast(layoutDoc._docFilters, listSpec("string"), []);
-    for (let i = 0; i < docFilters.length; i++) {
-        const fields = docFilters[i].split(":"); // split into key:value:modifiers
+    for (let filter of docFilters) {
+        const fields = filter.split(":"); // split into key:value:modifiers
         if (fields[0] === facetHeader && fields[1] === facetValue) {
             return fields[2];
         }
diff --git a/src/client/views/search/SearchBox.tsx b/src/client/views/search/SearchBox.tsx
index c559d4eb7..13fcccdcf 100644
--- a/src/client/views/search/SearchBox.tsx
+++ b/src/client/views/search/SearchBox.tsx
@@ -122,8 +122,8 @@ export class SearchBox extends ViewBoxBaseComponent<FieldViewProps, SearchBoxDoc
 
         const filters: string[] = [];
 
-        for (let i = 0; i < initialfilters.length; i++) {
-            const fields = initialfilters[i].split(":");
+        for (let initFilter of initialfilters) {
+            const fields = initFilter.split(":");
             if (fields[2] !== undefined) {
                 filters.push(fields[0]);
                 filters.push(fields[1]);