performance fixes - don't invalidate as much by using reactions in place of computd values; don't make things active when things are dragged unless CanEmbed; fix for linkBox to use reaction.

2 files changed, 11 insertions, 3 deletions

diff --git a/src/client/util/DragManager.ts b/src/client/util/DragManager.ts
index ea13eaa5b..9d6bd4f60 100644
--- a/src/client/util/DragManager.ts
+++ b/src/client/util/DragManager.ts
@@ -329,7 +329,7 @@ export namespace DragManager {
         DocDragData = dragData as DocumentDragData;
         const batch = UndoManager.StartBatch(dragUndoName ?? 'document drag');
         eles = eles.filter(e => e);
-        CanEmbed = dragData.canEmbed || false;
+        SnappingManager.SetCanEmbed(dragData.canEmbed || false);
         if (!dragDiv) {
             dragDiv = document.createElement('div');
             dragDiv.className = 'dragManager-dragDiv';
@@ -455,7 +455,7 @@ export namespace DragManager {
         runInAction(() => docsBeingDragged.push(...docsToDrag));
 
         const hideDragShowOriginalElements = (hide: boolean) => {
-            dragLabel.style.display = hide && !CanEmbed ? '' : 'none';
+            dragLabel.style.display = hide && !SnappingManager.GetCanEmbed() ? '' : 'none';
             !hide && dragElements.map(dragElement => dragElement.parentNode === dragDiv && dragDiv.removeChild(dragElement));
             setTimeout(() => eles.forEach(ele => (ele.hidden = hide)));
         };
@@ -482,6 +482,7 @@ export namespace DragManager {
             SnappingManager.SetIsDragging(false);
             if (batch.end() && undo) UndoManager.Undo();
             docsBeingDragged.length = 0;
+            SnappingManager.SetCanEmbed(false);
         });
         var startWindowDragTimer: any;
         const moveHandler = (e: PointerEvent) => {
@@ -588,7 +589,7 @@ export namespace DragManager {
                 altKey: e.altKey,
                 metaKey: e.metaKey,
                 ctrlKey: e.ctrlKey,
-                embedKey: CanEmbed,
+                embedKey: SnappingManager.GetCanEmbed(),
             },
         };
         target.dispatchEvent(new CustomEvent<DropEvent>('dashPreDrop', dropArgs));
diff --git a/src/client/util/SnappingManager.ts b/src/client/util/SnappingManager.ts
index 3cb41ab4d..c0cd94067 100644
--- a/src/client/util/SnappingManager.ts
+++ b/src/client/util/SnappingManager.ts
@@ -5,6 +5,7 @@ export namespace SnappingManager {
     class Manager {
         @observable IsDragging: boolean = false;
         @observable IsResizing: Doc | undefined;
+        @observable CanEmbed: boolean = false;
         @observable public horizSnapLines: number[] = [];
         @observable public vertSnapLines: number[] = [];
         @action public clearSnapLines() {
@@ -38,10 +39,16 @@ export namespace SnappingManager {
     export function SetIsResizing(doc: Doc | undefined) {
         runInAction(() => (manager.IsResizing = doc));
     }
+    export function SetCanEmbed(canEmbed: boolean) {
+        runInAction(() => (manager.CanEmbed = canEmbed));
+    }
     export function GetIsDragging() {
         return manager.IsDragging;
     }
     export function GetIsResizing() {
         return manager.IsResizing;
     }
+    export function GetCanEmbed() {
+        return manager.CanEmbed;
+    }
 }