diff options
author | bobzel <zzzman@gmail.com> | 2024-01-11 13:18:29 -0500 |
---|---|---|
committer | bobzel <zzzman@gmail.com> | 2024-01-11 13:18:29 -0500 |
commit | 6f278fdf5882bd7c936d64f4da8bf75c34196311 (patch) | |
tree | c4cea30f585ab562585c6b203813b4f52fb65d94 /src/client/views/nodes/DataVizBox/components/LineChart.tsx | |
parent | 06aaa5d58b62e7c85a81ce6b592c96cd13d16dd3 (diff) |
fixed obervable values not updateing because of component functions being defined as vairables
Diffstat (limited to 'src/client/views/nodes/DataVizBox/components/LineChart.tsx')
-rw-r--r-- | src/client/views/nodes/DataVizBox/components/LineChart.tsx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/client/views/nodes/DataVizBox/components/LineChart.tsx b/src/client/views/nodes/DataVizBox/components/LineChart.tsx index 50a8bf83d..2a9a8b354 100644 --- a/src/client/views/nodes/DataVizBox/components/LineChart.tsx +++ b/src/client/views/nodes/DataVizBox/components/LineChart.tsx @@ -89,7 +89,7 @@ export class LineChart extends ObservableReactComponent<LineChartProps> { componentWillUnmount() { Array.from(Object.keys(this._disposers)).forEach(key => this._disposers[key]()); } - componentDidMount = () => { + componentDidMount() { this._disposers.chartData = reaction( () => ({ dataSet: this._lineChartData, w: this.width, h: this.height }), ({ dataSet, w, h }) => { @@ -124,7 +124,7 @@ export class LineChart extends ObservableReactComponent<LineChartProps> { }, { fireImmediately: true } ); - }; + } // anything that doesn't need to be recalculated should just be stored as drawCharts (i.e. computed values) and drawChart is gonna iterate over these observables and generate svgs based on that |