trying to improve how data / layout / root and templtae docs are accessed.

2 files changed, 19 insertions, 26 deletions

diff --git a/src/client/views/nodes/formattedText/FormattedTextBox.tsx b/src/client/views/nodes/formattedText/FormattedTextBox.tsx
index b84575389..9078648e9 100644
--- a/src/client/views/nodes/formattedText/FormattedTextBox.tsx
+++ b/src/client/views/nodes/formattedText/FormattedTextBox.tsx
@@ -245,9 +245,8 @@ export class FormattedTextBox extends ViewBoxAnnotatableComponent<FormattedTextB
                 if (target) {
                     anchor.followLinkAudio = true;
                     let stopFunc: () => void = emptyFunction;
-                    const targetData = target[DocData];
-                    targetData.mediaState = mediaState.Recording;
-                    DictationManager.recordAudioAnnotation(targetData, Doc.LayoutFieldKey(target), stop => { stopFunc = stop }); // prettier-ignore
+                    target.$mediaState = mediaState.Recording;
+                    DictationManager.recordAudioAnnotation(target[DocData], Doc.LayoutFieldKey(target), stop => { stopFunc = stop }); // prettier-ignore
 
                     const reactionDisposer = reaction(
                         () => target.mediaState,
@@ -1067,7 +1066,7 @@ export class FormattedTextBox extends ViewBoxAnnotatableComponent<FormattedTextB
                 };
                 const link = CreateLinkToActiveAudio(textanchorFunc, false).lastElement();
                 if (link) {
-                    link[DocData].isDictation = true;
+                    link.$isDictation = true;
                     const audioanchor = Cast(link.link_anchor_2, Doc, null);
                     const textanchor = Cast(link.link_anchor_1, Doc, null);
                     if (audioanchor) {
@@ -1077,7 +1076,7 @@ export class FormattedTextBox extends ViewBoxAnnotatableComponent<FormattedTextB
                             audioId: audioanchor[Id],
                             textId: textanchor[Id],
                         });
-                        textanchor[DocData].title = 'dictation:' + audiotag.attrs.timeCode;
+                        textanchor.$title = 'dictation:' + audiotag.attrs.timeCode;
                         const tr = this.EditorView.state.tr.insert(this.EditorView.state.doc.content.size, audiotag);
                         const tr2 = tr.setSelection(TextSelection.create(tr.doc, tr.doc.content.size));
                         this.EditorView.dispatch(tr.setSelection(TextSelection.create(tr2.doc, tr2.doc.content.size)));
diff --git a/src/client/views/nodes/formattedText/RichTextRules.ts b/src/client/views/nodes/formattedText/RichTextRules.ts
index f3ec6cc9d..77c00537b 100644
--- a/src/client/views/nodes/formattedText/RichTextRules.ts
+++ b/src/client/views/nodes/formattedText/RichTextRules.ts
@@ -84,9 +84,8 @@ export class RichTextRules {
             // Create annotation to a field on the text document
             new InputRule(/>::$/, (state, match, start, end) => {
                 const creator = (doc: Doc) => {
-                    const textDoc = this.Document[DocData];
-                    const numInlines = NumCast(textDoc.inlineTextCount);
-                    textDoc.inlineTextCount = numInlines + 1;
+                    const numInlines = NumCast(this.Document.$inlineTextCount);
+                    this.Document.$inlineTextCount = numInlines + 1;
                     const node = state.doc.resolve(start).nodeAfter;
                     const newNode = schema.nodes.dashComment.create({ docId: doc[Id], reflow: false });
                     const dashDoc = schema.nodes.dashDoc.create({ width: 75, height: 35, title: 'dashDoc', docId: doc[Id], float: 'right' });
@@ -109,16 +108,15 @@ export class RichTextRules {
             }),
             // Create annotation to a field on the text document
             new InputRule(/>>$/, (state, match, start, end) => {
-                const textDoc = this.Document[DocData];
-                const numInlines = NumCast(textDoc.inlineTextCount);
-                textDoc.inlineTextCount = numInlines + 1;
-                const inlineFieldKey = 'inline' + numInlines; // which field on the text document this annotation will write to
-                const inlineLayoutKey = 'layout_' + inlineFieldKey; // the field holding the layout string that will render the inline annotation
+                const numInlines = NumCast(this.Document.$inlineTextCount);
+                this.Document.$inlineTextCount = numInlines + 1;
+                const inlineFieldKey = '$inline' + numInlines; // which field on the text document this annotation will write to
+                const inlineLayoutKey = '$layout_' + inlineFieldKey; // the field holding the layout string that will render the inline annotation
                 const textDocInline = Docs.Create.TextDocument('', {
                     _layout_fieldKey: inlineLayoutKey,
                     _width: 75,
                     _height: 35,
-                    annotationOn: textDoc,
+                    annotationOn: this.Document[DocData],
                     _layout_fitWidth: true,
                     _layout_autoHeight: true,
                     text_fontSize: '9px',
@@ -128,9 +126,9 @@ export class RichTextRules {
                 textDocInline.title_custom = true; // And make sure that it's 'custom' so that editing text doesn't change the title of the containing doc
                 textDocInline.isTemplateForField = inlineFieldKey; // this is needed in case the containing text doc is converted to a template at some point
                 textDocInline.isDataDoc = true;
-                textDocInline.proto = textDoc; // make the annotation inherit from the outer text doc so that it can resolve any nested field references, e.g., [[field]]
-                textDoc[inlineLayoutKey] = FormattedTextBox.LayoutString(inlineFieldKey); // create a layout string for the layout key that will render the annotation text
-                textDoc[inlineFieldKey] = ''; // set a default value for the annotation
+                textDocInline.proto = this.Document[DocData]; // make the annotation inherit from the outer text doc so that it can resolve any nested field references, e.g., [[field]]
+                this.Document[inlineLayoutKey] = FormattedTextBox.LayoutString(inlineFieldKey); // create a layout string for the layout key that will render the annotation text
+                this.Document[inlineFieldKey] = ''; // set a default value for the annotation
                 const node = state.doc.resolve(start).nodeAfter;
                 const newNode = schema.nodes.dashComment.create({ docId: textDocInline[Id], reflow: true });
                 const dashDoc = schema.nodes.dashDoc.create({ width: 75, height: 35, title: 'dashDoc', docId: textDocInline[Id], float: 'right' });
@@ -334,18 +332,14 @@ export class RichTextRules {
                     if (value?.includes(',') && !value.startsWith('((')) {
                         const values = value.split(',');
                         const strs = values.some(v => !v.match(/^[-]?[0-9.]$/));
-                        this.Document[DocData][fieldKey] = strs ? new List<string>(values) : new List<number>(values.map(v => Number(v)));
+                        this.Document['$' + fieldKey] = strs ? new List<string>(values) : new List<number>(values.map(v => Number(v)));
                     } else if (value) {
                         Doc.SetField(
                             this.Document,
                             fieldKey,
                             assign + value,
                             Doc.IsDataProto(this.Document) ? true : undefined,
-                            assign.includes(':=')
-                                ? undefined
-                                : (gptval: FieldResult) => {
-                                      (dataDoc ? this.Document[DocData] : this.Document)[fieldKey] = gptval as string;
-                                  }
+                            assign.includes(':=') ? undefined : (gptval: FieldResult) => (this.Document[(dataDoc ? '$' : '_') + fieldKey] = gptval as string)
                         );
                         if (fieldKey === this.TextBox.fieldKey) return this.TextBox.EditorView!.state.tr;
                     }
@@ -399,11 +393,11 @@ export class RichTextRules {
             new InputRule(/#(@?[a-zA-Z_-]+[a-zA-Z_\-0-9]*)\s$/, (state, match, start, end) => {
                 const tag = match[1];
                 if (!tag) return state.tr;
-                // this.Document[DocData]['#' + tag] = '#' + tag;
-                const tags = StrListCast(this.Document[DocData].tags);
+                // this.Document[['$#' + tag] = '#' + tag;
+                const tags = StrListCast(this.Document.$tags);
                 if (!tags.includes(tag)) {
                     tags.push(tag);
-                    this.Document[DocData].tags = new List<string>(tags);
+                    this.Document.$tags = new List<string>(tags);
                     this.Document._layout_showTags = true;
                 }
                 const fieldView = state.schema.nodes.dashField.create({ fieldKey: tag.startsWith('@') ? tag.replace(/^@/, '') : '#' + tag });