aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTyler Schicke <tyler_schicke@brown.edu>2019-07-19 19:23:01 -0400
committerTyler Schicke <tyler_schicke@brown.edu>2019-07-19 19:23:01 -0400
commit6da5737c72abe18c366889273a179a3bf94351be (patch)
treef3c01ab5a0e05694c24bc48e7a5af43ed1cfdd59 /src
parent8854d3277541a67aef4187b5d3592bea5a7fcfa2 (diff)
Added caching to computed fields
Diffstat (limited to 'src')
-rw-r--r--src/new_fields/ScriptField.ts5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/new_fields/ScriptField.ts b/src/new_fields/ScriptField.ts
index b5b1595cf..e8a1ea28a 100644
--- a/src/new_fields/ScriptField.ts
+++ b/src/new_fields/ScriptField.ts
@@ -5,6 +5,7 @@ import { serializable, createSimpleSchema, map, primitive, object, deserialize,
import { Deserializable } from "../client/util/SerializationHelper";
import { Doc } from "../new_fields/Doc";
import { Plugins } from "./util";
+import { computedFn } from "mobx-utils";
function optional(propSchema: PropSchema) {
return custom(value => {
@@ -87,13 +88,13 @@ export class ScriptField extends ObjectField {
@Deserializable("computed", deserializeScript)
export class ComputedField extends ScriptField {
//TODO maybe add an observable cache based on what is passed in for doc, considering there shouldn't really be that many possible values for doc
- value(doc: Doc) {
+ value = computedFn((doc: Doc) => {
const val = this.script.run({ this: doc });
if (val.success) {
return val.result;
}
return undefined;
- }
+ });
}
export namespace ComputedField {