1 files changed, 38 insertions, 41 deletions

diff --git a/src/client/util/LinkManager.ts b/src/client/util/LinkManager.ts
index 7a12a8580..2b0ce1d3d 100644
--- a/src/client/util/LinkManager.ts
+++ b/src/client/util/LinkManager.ts
@@ -19,7 +19,8 @@ import { Cast, StrCast } from '../../fields/Types';
 export class LinkManager {
     @observable static _instance: LinkManager;
     @observable static userLinkDBs: Doc[] = [];
-    public static currentLink: Opt<Doc>;
+    @observable public static currentLink: Opt<Doc>;
+    @observable public static currentLinkAnchor: Opt<Doc>;
     public static get Instance() {
         return LinkManager._instance;
     }
@@ -43,7 +44,6 @@ export class LinkManager {
                         if (a1 instanceof Doc && a2 instanceof Doc && ((a1.author !== undefined && a2.author !== undefined) || link.author === Doc.CurrentUserEmail)) {
                             Doc.GetProto(a1)[DirectLinksSym].add(link);
                             Doc.GetProto(a2)[DirectLinksSym].add(link);
-                            Doc.GetProto(link)[DirectLinksSym].add(link);
                         }
                     })
                 );
@@ -64,40 +64,42 @@ export class LinkManager {
         };
         const watchUserLinkDB = (userLinkDBDoc: Doc) => {
             LinkManager.links.push(...DocListCast(userLinkDBDoc.data));
-            const toRealField = (field: Field) => (field instanceof ProxyField ? field.value() : field); // see List.ts.  data structure is not a simple list of Docs, but a list of ProxyField/Fields
-            observe(
-                userLinkDBDoc.data as Doc,
-                change => {
-                    // observe pushes/splices on a user link DB 'data' field (should only happen for local changes)
-                    switch (change.type as any) {
-                        case 'splice':
-                            (change as any).added.forEach((link: any) => addLinkToDoc(toRealField(link)));
-                            (change as any).removed.forEach((link: any) => remLinkFromDoc(toRealField(link)));
-                            break;
-                        case 'update': //let oldValue = change.oldValue;
-                    }
-                },
-                true
-            );
-            observe(
-                userLinkDBDoc,
-                'data', // obsever when a new array of links is assigned as the link DB 'data' field (should happen whenever a remote user adds/removes a link)
-                change => {
-                    switch (change.type as any) {
-                        case 'update':
-                            Promise.all([...((change.oldValue as any as Doc[]) || []), ...((change.newValue as any as Doc[]) || [])]).then(doclist => {
-                                const oldDocs = doclist.slice(0, ((change.oldValue as any as Doc[]) || []).length);
-                                const newDocs = doclist.slice(((change.oldValue as any as Doc[]) || []).length, doclist.length);
+            const toRealField = (field: Field) => (field instanceof ProxyField ? field.value : field); // see List.ts.  data structure is not a simple list of Docs, but a list of ProxyField/Fields
+            if (userLinkDBDoc.data) {
+                observe(
+                    userLinkDBDoc.data,
+                    change => {
+                        // observe pushes/splices on a user link DB 'data' field (should only happen for local changes)
+                        switch (change.type as any) {
+                            case 'splice':
+                                (change as any).added.forEach((link: any) => addLinkToDoc(toRealField(link)));
+                                (change as any).removed.forEach((link: any) => remLinkFromDoc(toRealField(link)));
+                                break;
+                            case 'update': //let oldValue = change.oldValue;
+                        }
+                    },
+                    true
+                );
+                observe(
+                    userLinkDBDoc,
+                    'data', // obsever when a new array of links is assigned as the link DB 'data' field (should happen whenever a remote user adds/removes a link)
+                    change => {
+                        switch (change.type as any) {
+                            case 'update':
+                                Promise.all([...((change.oldValue as any as Doc[]) || []), ...((change.newValue as any as Doc[]) || [])]).then(doclist => {
+                                    const oldDocs = doclist.slice(0, ((change.oldValue as any as Doc[]) || []).length);
+                                    const newDocs = doclist.slice(((change.oldValue as any as Doc[]) || []).length, doclist.length);
 
-                                const added = newDocs?.filter(link => !(oldDocs || []).includes(link));
-                                const removed = oldDocs?.filter(link => !(newDocs || []).includes(link));
-                                added?.forEach((link: any) => addLinkToDoc(toRealField(link)));
-                                removed?.forEach((link: any) => remLinkFromDoc(toRealField(link)));
-                            });
-                    }
-                },
-                true
-            );
+                                    const added = newDocs?.filter(link => !(oldDocs || []).includes(link));
+                                    const removed = oldDocs?.filter(link => !(newDocs || []).includes(link));
+                                    added?.forEach((link: any) => addLinkToDoc(toRealField(link)));
+                                    removed?.forEach((link: any) => remLinkFromDoc(toRealField(link)));
+                                });
+                        }
+                    },
+                    true
+                );
+            }
         };
         observe(
             LinkManager.userLinkDBs,
@@ -144,12 +146,7 @@ export class LinkManager {
         return this.relatedLinker(anchor);
     } // finds all links that contain the given anchor
     public getAllDirectLinks(anchor: Doc): Doc[] {
-        // FIXME:glr Why is Doc undefined?
-        if (Doc.GetProto(anchor)[DirectLinksSym]) {
-            return Array.from(Doc.GetProto(anchor)[DirectLinksSym]);
-        } else {
-            return [];
-        }
+        return Array.from(Doc.GetProto(anchor)[DirectLinksSym] ?? []);
     } // finds all links that contain the given anchor
 
     relatedLinker = computedFn(function relatedLinker(this: any, anchor: Doc): Doc[] {