potentially buggy normals and first update to phong

1 files changed, 3 insertions, 6 deletions

diff --git a/src/raytracer/raytracer.cpp b/src/raytracer/raytracer.cpp
index acb229a..b393d40 100644
--- a/src/raytracer/raytracer.cpp
+++ b/src/raytracer/raytracer.cpp
@@ -127,12 +127,9 @@ glm::vec4 RayTracer::getPixelFromRay(
         }
     }
 
-    glm::vec3 normalObject = getNormal(closestIntersectionObj, intersectedShape, scene);
-    glm::vec3 normalWorld =
-            (
-                    glm::inverse(glm::transpose(intersectedShape.ctm))
-                    * glm::vec4(normalObject, 0.f)
-            ).xyz();
+    glm::vec4 normalObject = glm::normalize(getNormal(closestIntersectionObj, intersectedShape, scene));
+    // update
+    glm::vec4 normalWorld = glm::inverse(glm::transpose(intersectedShape.ctm)) * glm::vec4(normalObject);
 
     return illuminatePixel(closestIntersectionWorld, normalWorld, -dWorld, intersectedShape, scene, depth);
 }