diff options
| author | Ivan Chen <ivan@tagg.id> | 2021-05-18 18:26:01 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-18 18:26:01 -0400 |
| commit | bf1c2fdc6314bee438453c01db46ec99e5beef50 (patch) | |
| tree | 8b1929d24969489681bc5de374c8437f66683f5f /.github | |
| parent | d515765a9a24df493fb52f357ea94a15203ac33b (diff) | |
| parent | b499035b1287ce12fc57f272c3c208295a6e16be (diff) | |
Merge pull request #428 from TaggiD-Inc/tma868-update-pr-templates
[TMA-868] Update PR Template
Diffstat (limited to '.github')
| -rw-r--r-- | .github/pull_request_template.md | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b39e49be..6d068539 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,30 +7,24 @@ ## Description <!--- Describe your changes in detail --> -## Packages added (using `yarn add` or `yarn add --dev`) -<!--- List all packages that were added in this PR and provide a succinct explanation of their use cases --> -- **package-name** — Use case of package within project - ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> +- [ ] Requires testing on different screen sizes (iPhone 8, iPhone 11) (optional) +- [ ] Requires testing on different screen sizes (iPhone 12 mini, iPhone 12 Pro Max) (optional) ## Screenshots (if appropriate) -## Types of changes -<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> -- [ ] Bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to change) -- [ ] Documentation/repository update +<!--- ## Packages added (using `yarn add` or `yarn add --dev`) --> +<!--- List all packages that were added in this PR and provide a succinct explanation of their use cases --> +<!--- - **package-name** — Use case of package within project --> ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask! --> - [ ] I thoroughly tested my changes and ensured that they integrate with existing functionality. -- [ ] I ran `yarn lint` and `yarn type`, and I fixed any syntax or type errors that came up. - [ ] I ran `git pull --rebase upstream master` in my branch and resolved any merge conflicts on my end. -- [ ] I clearly documented and detailed my code where I deemed it necessary to do so. +- [ ] I documented my code in line with our [style guide](https://taggid.atlassian.net/wiki/spaces/~523670961/pages/891944961). - [ ] My changes require a change to the documentation... - [ ] ... which I have updated accordingly. |