Convert local badges to display badges, Cleanup code

1 files changed, 16 insertions, 29 deletions

diff --git a/src/screens/suggestedPeople/SPBody.tsx b/src/screens/suggestedPeople/SPBody.tsx
index c1064224..10ad63f0 100644
--- a/src/screens/suggestedPeople/SPBody.tsx
+++ b/src/screens/suggestedPeople/SPBody.tsx
@@ -1,19 +1,24 @@
 import {useNavigation} from '@react-navigation/native';
 import React, {Fragment, useEffect, useMemo, useState} from 'react';
-import {ImageSourcePropType, StyleSheet, Text, View} from 'react-native';
+import {StyleSheet, Text, View} from 'react-native';
 import {Image} from 'react-native-animatable';
 import {TouchableOpacity} from 'react-native-gesture-handler';
 import RequestedButton from '../../assets/ionicons/requested-button.svg';
 import {UniversityIcon} from '../../components';
 import {BadgeIcon, MutualFriends} from '../../components/suggestedPeople';
-import {BADGE_DATA} from '../../constants/badges';
 import {
   ProfilePreviewType,
   ScreenType,
   SuggestedPeopleDataType,
-  UniversityBadge,
+  UniversityBadgeDisplayType,
 } from '../../types';
-import {isIPhoneX, normalize, SCREEN_HEIGHT, SCREEN_WIDTH} from '../../utils';
+import {
+  badgesToDisplayBadges,
+  isIPhoneX,
+  normalize,
+  SCREEN_HEIGHT,
+  SCREEN_WIDTH,
+} from '../../utils';
 
 interface SPBodyProps {
   item: SuggestedPeopleDataType;
@@ -39,30 +44,12 @@ const SPBody: React.FC<SPBodyProps> = ({
 }) => {
   const firstItem = itemIndex === 0;
   const screenType = ScreenType.SuggestedPeople;
-  const [localBadges, setLocalBadges] = useState<
-    {
-      badge: UniversityBadge;
-      img: ImageSourcePropType;
-    }[]
+  const [displayBadges, setDisplayBadges] = useState<
+    UniversityBadgeDisplayType[]
   >([]);
   const navigation = useNavigation();
   useEffect(() => {
-    const newBadges: {badge: UniversityBadge; img: any}[] = [];
-    const findBadgeIcons = (badge: UniversityBadge) => {
-      BADGE_DATA[university]?.forEach((item) => {
-        if (item.title === badge.category) {
-          item.data.forEach((object) => {
-            if (object.badgeName === badge.name) {
-              newBadges.push({badge, img: object.badgeImage});
-            }
-          });
-        }
-      });
-      setLocalBadges(newBadges);
-    };
-    badges
-      ? badges.forEach((badge) => findBadgeIcons(badge))
-      : console.log('NO BADGES FOUND');
+    setDisplayBadges(badgesToDisplayBadges(badges));
   }, []);
 
   const FriendButton = () => {
@@ -131,10 +118,10 @@ const SPBody: React.FC<SPBodyProps> = ({
   const Badges = () => (
     // Badges aligned left and spaced as if there are 5 items
     <View style={styles.badgeContainer}>
-      {localBadges.map(({badge, img}, index) => (
-        <BadgeIcon key={index} badge={{...badge, img}} style={styles.badge} />
+      {displayBadges.map((displayBadge, index) => (
+        <BadgeIcon key={index} badge={displayBadge} style={styles.badge} />
       ))}
-      {[0, 0, 0, 0, 0].splice(localBadges.length, 5).map((_, index) => (
+      {[0, 0, 0, 0, 0].splice(displayBadges.length, 5).map((_, index) => (
         <View key={index} style={styles.badge} />
       ))}
     </View>
@@ -159,7 +146,7 @@ const SPBody: React.FC<SPBodyProps> = ({
               {user.id !== loggedInUserId && <FriendButton />}
             </View>
           </View>
-          {localBadges.length !== 0 && <Badges />}
+          {displayBadges.length !== 0 && <Badges />}
           <View style={styles.marginManager}>
             <MutualFriends user={user} friends={mutual_friends} />
           </View>