diff options
author | Michael <michael.foiani@gmail.com> | 2021-07-02 15:56:56 -0400 |
---|---|---|
committer | Michael <michael.foiani@gmail.com> | 2021-07-02 15:56:56 -0400 |
commit | 222c7ab62e57f7dec41d8a14de3768ee9a63fc8e (patch) | |
tree | 98ec94309c3349ce5afea46728e1f3683196cef2 /src | |
parent | 8cb0b333a0d6fc36b909dc7256d1518f15ae5da4 (diff) |
Remove comments added from pr review. Also, clean some code that was suggested from pr review.
Diffstat (limited to 'src')
-rw-r--r-- | src/components/common/NavigationIcon.tsx | 19 | ||||
-rw-r--r-- | src/routes/main/MainStackNavigator.tsx | 4 | ||||
-rw-r--r-- | src/routes/main/MainStackScreen.tsx | 18 |
3 files changed, 8 insertions, 33 deletions
diff --git a/src/components/common/NavigationIcon.tsx b/src/components/common/NavigationIcon.tsx index f97bb861..debb36b3 100644 --- a/src/components/common/NavigationIcon.tsx +++ b/src/components/common/NavigationIcon.tsx @@ -69,22 +69,15 @@ const NavigationIcon = (props: NavigationIconProps) => { return ( <View style={styles.container}> <TouchableOpacity {...props}> - <Image source={imgSrc} style={getStyles(props.isBigger ?? false)} /> + <Image + source={imgSrc} + style={props.isBigger ? styles.biggerIcon : styles.icon} + /> </TouchableOpacity> </View> ); }; -const getStyles = (isBigger: boolean) => - isBigger ? biggerIconStyles.icon : styles.icon; - -const biggerIconStyles = StyleSheet.create({ - icon: { - height: 44, - width: 44, - }, -}); - const styles = StyleSheet.create({ container: { flex: 1, @@ -101,6 +94,10 @@ const styles = StyleSheet.create({ height: 28, width: 28, }, + biggerIcon: { + height: 44, + width: 44, + }, }); export default NavigationIcon; diff --git a/src/routes/main/MainStackNavigator.tsx b/src/routes/main/MainStackNavigator.tsx index f12072e6..bc023da8 100644 --- a/src/routes/main/MainStackNavigator.tsx +++ b/src/routes/main/MainStackNavigator.tsx @@ -14,10 +14,6 @@ export type MainStackParams = { SuggestedPeople: { screenType: ScreenType; }; - /* - Search: { - screenType: ScreenType; - }; */ Upload: { screenType: ScreenType; }; diff --git a/src/routes/main/MainStackScreen.tsx b/src/routes/main/MainStackScreen.tsx index e19df2c2..948f37b8 100644 --- a/src/routes/main/MainStackScreen.tsx +++ b/src/routes/main/MainStackScreen.tsx @@ -26,7 +26,6 @@ import { PrivacyScreen, ProfileScreen, RequestContactsAccess, - // SearchScreen, SettingsScreen, SocialMediaTaggs, SuggestedPeopleScreen, @@ -60,7 +59,6 @@ interface MainStackProps { const MainStackScreen: React.FC<MainStackProps> = ({route}) => { const {screenType} = route.params; - // const isSearchTab = screenType === ScreenType.Search; const isNotificationsTab = screenType === ScreenType.Notifications; const isSuggestedPeopleTab = screenType === ScreenType.SuggestedPeople; const isUploadTab = screenType === ScreenType.Upload; @@ -69,9 +67,6 @@ const MainStackScreen: React.FC<MainStackProps> = ({route}) => { switch (screenType) { case ScreenType.Profile: return 'Profile'; - /* - case ScreenType.Search: - return 'Search'; */ case ScreenType.Notifications: return 'Notifications'; case ScreenType.SuggestedPeople: @@ -103,19 +98,6 @@ const MainStackScreen: React.FC<MainStackProps> = ({route}) => { animationEnabled: false, }; - /* - Following was removed to eliminate search screen naviagtion - - {isSearchTab && ( - <MainStack.Screen - name="Search" - component={SearchScreen} - initialParams={{ screenType }} - /> - )} - - */ - const mainStackScreen = () => { return ( <MainStack.Navigator |