diff options
| author | Ivan Chen <ivan@tagg.id> | 2021-03-30 15:27:19 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-30 15:27:19 -0400 |
| commit | 6250ae2a6936bdb8e4b1cca538640fbb0d8c4c48 (patch) | |
| tree | 7fe5c6809650ba919102cc21218b74345aba1455 /src | |
| parent | e74f7d6572ed6cff565ecccbbb4561430ec7912f (diff) | |
| parent | 4366feca828974b93d1211662f1fb6ee825a2374 (diff) | |
Merge pull request #344 from IvanIFChen/hotfix-allow-access-settings
[HOTFIX] Allow navigation to settings page without onboarded SP
Diffstat (limited to 'src')
| -rw-r--r-- | src/components/profile/ProfileMoreInfoDrawer.tsx | 9 | ||||
| -rw-r--r-- | src/screens/profile/SettingsCell.tsx | 5 |
2 files changed, 5 insertions, 9 deletions
diff --git a/src/components/profile/ProfileMoreInfoDrawer.tsx b/src/components/profile/ProfileMoreInfoDrawer.tsx index f70f90d0..67e59747 100644 --- a/src/components/profile/ProfileMoreInfoDrawer.tsx +++ b/src/components/profile/ProfileMoreInfoDrawer.tsx @@ -36,13 +36,8 @@ const ProfileMoreInfoDrawer: React.FC<ProfileMoreInfoDrawerProps> = (props) => { }; const goToSettingsPage = () => { - if (profile.suggested_people_linked === 0) { - Alert.alert(ERROR_ATTEMPT_EDIT_SP); - } else { - // Sending undefined for updatedSelectedBadges to mark that there was no update yet - navigation.navigate('SettingsScreen'); - setIsOpen(false); - } + navigation.navigate('SettingsScreen'); + setIsOpen(false); }; const onBlockUnblock = () => { diff --git a/src/screens/profile/SettingsCell.tsx b/src/screens/profile/SettingsCell.tsx index d9fab821..852a29dc 100644 --- a/src/screens/profile/SettingsCell.tsx +++ b/src/screens/profile/SettingsCell.tsx @@ -35,7 +35,6 @@ const SettingsCell: React.FC<SettingsCellProps> = ({ if (suggested_people_linked === 0) { Alert.alert(ERROR_ATTEMPT_EDIT_SP); } else { - // Sending undefined for updatedSelectedBadges to mark that there was no update yet navigateTo('UpdateSPPicture', { editing: true, }); @@ -85,7 +84,9 @@ const SettingsCell: React.FC<SettingsCellProps> = ({ endExit: 'slide_out_right', }, }); - } else Linking.openURL(url); + } else { + Linking.openURL(url); + } } catch (error) { Alert.alert(error.message); } |